Skip to content

Porting to Swift 3 #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2016
Merged

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Mar 10, 2016

No description provided.

@moiseev
Copy link
Contributor Author

moiseev commented Mar 10, 2016

@phausler, I've just merged changes to Swift, so this one is good to go.

@jessesquires
Copy link
Contributor

Hey @moiseev 😄 -- This looks nearly identical to what was merged in #271. Should this be rebased on master again?

gribozavr added a commit that referenced this pull request Mar 10, 2016
@gribozavr gribozavr merged commit 3579f1f into swiftlang:master Mar 10, 2016
@gribozavr
Copy link
Contributor

Merging the PR to bring CI back to green.

@moiseev
Copy link
Contributor Author

moiseev commented Mar 10, 2016

It is indeed the same thing. #271 was merged and then reverted.

On Mar 9, 2016, at 18:21, Jesse Squires notifications@github.com wrote:

Hey @moiseev -- This looks nearly identical to what was merged in #271. Should this be rebased on master again?


Reply to this email directly or view it on GitHub.

@moiseev
Copy link
Contributor Author

moiseev commented Mar 10, 2016

Thanks, Dmitri! This one depends in the XCTest, so if you could merge that one as well...

On Mar 9, 2016, at 18:45, Dmitri Gribenko notifications@github.com wrote:

Merging the PR to bring CI back to green.


Reply to this email directly or view it on GitHub.

@moiseev
Copy link
Contributor Author

moiseev commented Mar 10, 2016

Here is the xctest pr: swiftlang/swift-corelibs-xctest#60

On Mar 9, 2016, at 19:33, Max Moiseev maxim_moiseev@apple.com wrote:

Thanks, Dmitri! This one depends in the XCTest, so if you could merge that one as well...

On Mar 9, 2016, at 18:45, Dmitri Gribenko notifications@github.com wrote:

Merging the PR to bring CI back to green.


Reply to this email directly or view it on GitHub.

@jessesquires
Copy link
Contributor

@moiseev -- ah, thanks for the clarification! 😄

@tfrank64
Copy link
Contributor

Maybe it has been mentioned somewhere, but is there any instruction on running Foundation now with all these Swift 3 changes. I'm struggling to get things going on OSX or Linux.

@moiseev
Copy link
Contributor Author

moiseev commented Mar 14, 2016

@tfrank64 you should not have to change anything. On Linux I used swift/utils/build-util --xctest --foundation -RT and then swift-corelibs-foundation/ninja test both before and after applying changes. What are the exact problems you have?

@tfrank64
Copy link
Contributor

@moiseev I'm uncertain what kind of issue I have now. I can run swift/utils/build-script --xctest --foundation -RT on the master branch of swift in Linux. With foundation, everything works on the master branch, but when I switch to my branch, the tests stop at my changes saying Trace/breakpoint trap (core dumped). So basically I'm not sure what that means or how to debug, because the debugging command ninja test gives me, needs lldb and apparently I don't have that

@moiseev
Copy link
Contributor Author

moiseev commented Mar 15, 2016

@tfrank64 hm.. Since PR is not a very good place for such discussion, I would suggest posting detailed description of your problem to swift-dev mailing list, perhaps somebody has the solution already. At the very least it will be brought to attention of a much wider audience. Feel free to CC me.

@moiseev moiseev deleted the swift-3-api-guidelines branch April 26, 2016 21:29
atrick pushed a commit to atrick/swift-corelibs-foundation that referenced this pull request Jan 12, 2021
…g#281)

While fallback arguments are being used (either from the fallback build system or fallback settings from the primary build system), withhold semantic diagnostics from sourcekitd and all diagnostics from clangd. This helps prevent user confusion from spurious errors.

- Also remove the DocumentURI standardization in favor of proper equality + hash checks to work around the %40 --> @ encoding issue seen on CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants